Adds access control to flipflop controller #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: * adds shared secret key access to flipflop controller in all environments (dev / test were previously always accessible) * travis defaults to running `rake`, new way is `bin/rails test` Why: * the ability to easily toggle features for staff in PR and staging builds where they can confirm their current settings requires some form of dashboard and flipflop comes with one so why not use it How: * setting `ENV['FLIPFLOP_KEY']` and passing that value like `/flipflop?flipflop_key=thatthingyouset` will provide access to the dashboard where you can see all possible toggles and easily toggle features for your session * if you don't set `ENV['FLIPFLOP_KEY']` all access is denied to the dashboard but you can still toggle features via the `/toggle?feature=yourfeature` route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
environments (dev / test were previously always accessible)
rake, new way isbin/rails testWhy:
builds where they can confirm their current settings requires some
form of dashboard and flipflop comes with one so why not use it
How:
ENV['FLIPFLOP_KEY']and passing that value like/flipflop?flipflop_key=thatthingyousetwill provide access to thedashboard where you can see all possible toggles and easily toggle
features for your session
ENV['FLIPFLOP_KEY']all access is denied to thedashboard but you can still toggle features via the
/toggle?feature=yourfeatureroute