-
Notifications
You must be signed in to change notification settings - Fork 4
Adds in-app subject and author links #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm noticing a few things:
I'll keep digging but I think you're right that this needs some tweaking. Since it's a subtle problem, I think we should hold off on merging until we can figure out what's going on, but am happy to discuss if you have your finger on the button... |
|
I'm in no rush to merge. We can send this out for more feedback too. |
|
Subjects looking good now 🌈 |
frrrances
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my perspective, this is all 👍 - though we can wait for feedback from the team.
9b900b1 to
87c25b7
Compare
* local_browse feature now uses in_app links instead of external links to EDS UI for authors and subjects * external links are still used when local_browse is not enabled * changes subject queries to use `SU` not `DE` for subjects
87c25b7 to
ed0babe
Compare
to EDS UI for authors and subjects
NOTE: I'm not sure this is actually working as intended as I don't seem to get identical results browsing locally and via the EDS UI options.
HINT: https://mit-bento-staging-pr-182.herokuapp.com/toggle?feature=local_browse