Maintenance week 07 2024 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehanson8
commented
Jul 30, 2024
Comment on lines
+41
to
+43
| def ntransfercmd( | ||
| self, cmd: str, rest: str | int | None = None | ||
| ) -> tuple[socket, int | None]: |
There was a problem hiding this comment.
Nice find! Helpful to understand why it changed.
ghukill
approved these changes
Jul 30, 2024
Comment on lines
+41
to
+43
| def ntransfercmd( | ||
| self, cmd: str, rest: str | int | None = None | ||
| ) -> tuple[socket, int | None]: |
There was a problem hiding this comment.
Nice find! Helpful to understand why it changed.
| def _add_subelement( | ||
| self, | ||
| parent: ET._Element, # noqa: SLF001 | ||
| parent: ET._Element, |
There was a problem hiding this comment.
Minor, but always appreciate when we can remove linting overrides / ignores.
jonavellecuerdo
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Code updates look good to me! 😄 One small change request is for the README. Can you update the environment variables section to the format:
Environment Variables
Required
<ENV_VAR>=# <Description>.
<ENV_VAR>=# <Description>.Optional
<ENV_VAR>=# <Description>.
<ENV_VAR>=# <Description>.
jonavellecuerdo
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Updates app according to our maintenance week documentation.
How can a reviewer manually see the effects of these changes?
Run
make testandmakelint to confirm they still passIncludes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
NA
Developer
Code Reviewer(s)