Add support for running as AWS Lambda #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Lambda handler function. There are a few assumptions being made here. This assumes the Lambda will be triggered by a CloudWatch event and that the event will pass a JSON structure that indicates the type of feed to generate. The function is configured through environment variables. Env vars that contain sensitive information should be added to an AWS Secrets object. I'm making some guesses here as to how the event data and secrets get passed to the Lambda. The documentation suggests it's possible to pass JSON in both cases, but it's not entirely clear. Some adjustment may be required after attempting to run this in AWS.
JPrevost
approved these changes
Aug 2, 2018
carbon/app.py
Outdated
| return cfg | ||
|
|
||
|
|
||
| class Lambda: |
There was a problem hiding this comment.
I'm not sure this is a great class name as it isn't what it is or does, but instead is the context in which you might run it. I also don't have a better name so I'm not blocking on this, just kinda suggesting a pause to confirm it works okay for you in context and then either change or not ;)
|
Figuring out how to get this packaged into a lambda with the proprietary oracle library is going to be a PITA. I figured I'd do this part first, then sort out the packaging part. |
|
👍 |
Use a name that better reflects what the class does.
JPrevost
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Lambda handler function. There are a few assumptions being
made here. This assumes the Lambda will be triggered by a CloudWatch
event and that the event will pass a JSON structure that indicates the
type of feed to generate. The function is configured through environment
variables. Env vars that contain sensitive information should be added
to an AWS Secrets object.
I'm making some guesses here as to how the event data and secrets get
passed to the Lambda. The documentation suggests it's possible to pass
JSON in both cases, but it's not entirely clear. Some adjustment may be
required after attempting to run this in AWS.