Add flake8 to test suite #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #40. This adds a tox environment for flake8 and a corresponding entry to the travis test matrix. Also fixes all the flake8 errors.
JPrevost
reviewed
Aug 8, 2018
| .where(func.upper(dlcs.c.ORG_HIER_SCHOOL_AREA_NAME).in_(AREAS)) \ | ||
| .where(persons.c.PERSONNEL_SUBAREA_CODE.in_(PS_CODES)) \ | ||
| .where(func.upper(persons.c.JOB_TITLE).in_(TITLES)) | ||
| .where(func.upper(persons.c.JOB_TITLE).in_(TITLES)) # noqa: E711 |
There was a problem hiding this comment.
Unfortunately, this is required due to how SQLAlchemy is handling the operator overloading for things like some_column != None. pep8 says the comparison should be some_column is not None but this will not generate valid SQL.
JPrevost
approved these changes
Aug 8, 2018
|
I don't have a problem with also adding CodeClimate as another check during the Travis build. Feel free to submit a PR. However, I'm going to continue to insist on also using flake8 because it provides more checks than what CodeClimate will do. flake8 is a wrapper around pycodestyle, which is what CodeClimate runs, but it will also do additional checks for things like unused imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40. This adds a tox environment for flake8 and a corresponding
entry to the travis test matrix. Also fixes all the flake8 errors.