Containerize carbon #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 10, 2018 13:44
Since we are switching to Fargate, this changes the build process to create a container. The app code itself has not changed as it already supports this mode of operation. This commit adds the necessary tooling to create the container. The Makefile has been updated to handle the whole build process. Running `make dist` should result in built container. Versioning of the app has been switched from semver to the commit hash. The travis deploy step will need to be updated once we are set up with ECR.
This fixes an issue where pip won't install a wheel whose version number starts with a letter. I've also moved the required S3 libs into a vendor directory to save having to download them every time you run `make clean`.
Since we're deploying into a container we control, we can just install libaio with the system package manager.
The deploy stage on travis will now build the image and push it to ECR. A new make target has been added to handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abandons Lambda for Fargate. The app itself has not changed aside from a different versioning scheme. The makefile has been updated to handle most of the build process. If you want to see the changes, make sure your aws cli credentials are configured and run:
This should output the usage message for carbon.