Add Fargate functionality #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a few pieces to make carbon work on Fargate. The main change is to add SNS notification directly into the app. Cloudwatch logging from the container's stdout is a little flakey. The build process will now publish the container to both the stage and prod ECR repos. With real CI/CD we'd just publish to stage, but with Travis this is the best we can do.
hakbailey
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few pieces to make carbon work on Fargate. The main change
is to add SNS notification directly into the app. Cloudwatch logging
from the container's stdout is a little flakey. The build process will
now publish the container to both the stage and prod ECR repos. With
real CI/CD we'd just publish to stage, but with Travis this is the best
we can do.