Skip to content

Conversation

@ehanson8
Copy link
Contributor

@ehanson8 ehanson8 commented Mar 4, 2021

What does this PR do?

In preparation for some major refactoring, this is a collection of miscellaneous changes from recent testing. They are described in the order that they appear in the diff

  • Upgrades for Python 3.8
  • Corrects attrs package name
  • Creates a logs directory at startup if one doesn't already exist
  • Removes search CLI command which was just used for initial testing
  • Removes aux CLI group -This was not functioning as expected, I will revisit later after I finish the planned major refactoring
  • Adds a method for retrieving an object's UUID based on a handle and a corresponding test
  • Sorts bitstreams before posting to an item to ensure numbered bitstreams are in the correct order
  • Refactors the 2 functions for creating JSON metadata from CSV to handle delimited fields containing multiple entries
  • Updating testing variable names for greater clarity

Includes new or updated dependencies?

YES

Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test changes are important because right now the tests aren't checking that all of the application logic works as expected. Everything else is just nonblocking suggestions :)

@ehanson8 ehanson8 merged commit 85a27ca into refactor Mar 11, 2021
@ehanson8 ehanson8 deleted the misc-refactoring branch March 11, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants