major refactor #19
Merged
major refactor #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakbailey
suggested changes
Apr 7, 2021
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
Overall this is looking much better! See inline comments for some specific changes. At this point a lot of it is small stuff just to make the code cleaner, but there are a few things that are important. Happy to chat about any of it!
| yield reader | ||
|
|
||
|
|
||
| @pytest.fixture() |
Contributor
There was a problem hiding this comment.
I think this fixture can be removed? And any others that aren't being used.
Contributor
Author
There was a problem hiding this comment.
I will also handle this in the reconcile refactor
hakbailey
approved these changes
Apr 9, 2021
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
Good to squash and merge!
ehanson8
added a commit
that referenced
this pull request
Apr 10, 2021
* major refactor * Restructure code examples * PR updates * Code review fixes Co-authored-by: Helen Bailey <hbailey@mit.edu>
ehanson8
added a commit
that referenced
this pull request
Apr 26, 2021
* major refactor * Restructure code examples * PR updates * Code review fixes Co-authored-by: Helen Bailey <hbailey@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a fundamental refactoring of
dsapsthat was requested to be reviewed in its entirety.cli.pywas shifted toworkflows.py.metadata.pyandhelpers.pywere created to improve the overall organization of the code.Clientmethods was shifted tohelpers.py.conftest.pywas significantly expanded and actual CSV files were added as fixtures to give developers a better sense of the expected input files.Includes new or updated dependencies?
YES