reconcile refactor #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakbailey
suggested changes
Apr 14, 2021
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
Just a few small comments. Updating the helper tests should be done though, as some of them are currently using different object types than the functions they're testing.
ehanson8
force-pushed
the
reconcile-refactor
branch
from
e339f95 to
2fd06d3
Compare
ehanson8
force-pushed
the
reconcile-refactor
branch
from
2fd06d3 to
af56049
Compare
hakbailey
approved these changes
Apr 22, 2021
ehanson8
added a commit
that referenced
this pull request
Apr 26, 2021
* reconcile refactor * PR updates * Update cli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the
reconcilecommand for greater efficiency and removes unnecessary code.Includes new or updated dependencies?
NO