add tests #7
Merged
add tests #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravesm
suggested changes
Dec 9, 2019
tests/test_models.py
Outdated
| selected_collections = '' | ||
| url = f'/rest/filtered-items?query_field[]={key}&query_op[]=' | ||
| url += f'{query_type}&query_val[]={string}&collSel[]=' | ||
| url += f'{selected_collections}&limit=200&offset=' |
There was a problem hiding this comment.
Here again I would start with the query string as a dictionary. Since you aren't passing to requests in this case, you can use https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlencode to create the query string. Long formatting strings with lots of variables should generally be avoided if possible. They are too prone to typos and difficult to debug.
gravesm
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding tests for class methods and a endpoint correction
Includes new or updated dependencies?
NO