Skip to content

Conversation

@dornera
Copy link
Collaborator

@dornera dornera commented Feb 15, 2018

  1. Staging environment is all set (I think at least for this project)

-.travis.yml:
- master branch will by default go to staging (there's a comment as this will needed to be changed when merged)
-to push to prod, change env to Hamlet-prod (not ideal since there will be a change but I believe you said this should be ok for now. Just make sure to switch back once pushed to prod)

  1. Fixed aws.py allowed_hosts so don't have manual IP addresses and a few typos/wording
  2. Removed load balancer config file as it had to point a cert which would change per environment. This is done in Beanstalk in the environment settings and won't change.
  3. config.yml removed (no biggie). If we end up using the command line for EB we'll reinitialize each time.

@dornera
Copy link
Collaborator Author

dornera commented Feb 15, 2018

P.S. There was something weird with Travis -> EB deploy so the commits similar to "WTF" and "I don't know" was just an annoying temporary permission fluke which resolved itself

@coveralls
Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 88.668% when pulling 1b7ee81 on staging into cca2bcf on master.

Copy link
Owner

@thatandromeda thatandromeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash these commits into something with a descriptive commit message to clean up the history? (https://chris.beams.io/posts/git-commit/ is good if you want a reference on commit messages) After that this is 🌈 👍

1. Created and Tested Staging environment
2. Fixed Allowed_hosts in aws.py settings
3. Cleaned up unnecessary config files
@dornera dornera merged commit 2288e37 into master Feb 15, 2018
@dornera dornera deleted the staging branch April 8, 2018 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants