Deployment Automation - Dev/Stage/Prod Environment #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: The repository needs the tooling to enable deployes to AWS. How this addresses that need: * Add Terraform-generated Docker build commands to the Makefile * Add the dev-build GHA workflow Side effects of this change: None. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1416
* Add the stage-build GHA workflow * Add the prod-promote GHA workflow Relates to: https://mitlibraries.atlassian.net/browse/IN-1416
Contributor
Author
|
@ghukill ok, now it's ready for review. |
Pull Request Test Coverage Report for Build 16993523439Details
💛 - Coveralls |
ghukill
approved these changes
Aug 15, 2025
Contributor
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Looks good! A PR with a more fully functioning CLI is coming soon.
cabutlermit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
The repository needs the tooling to enable deploys to AWS.
Makefiledev-buildGHA workflowprod-promoteGHA workflowHow can a reviewer manually see the effects of these changes?
Download this branch locally and switch to it. Test the
make dist-devandmake publish-devto verify that theMakefilecommands work properly to push the container to the Dev1 ECR Repository.The
dev-buildGHA workflow should have run when this PR was opened and can be reviewed in the Actions tab.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)