Skip to content

Conversation

@cabutlermit
Copy link
Contributor

Developer Checklist

  • The README contains any additional info needed outside of the terraform docs generated
  • Any special variables have values configured in AWS SSM
  • Stakeholder approval has been confirmed (or is not needed)

What does this PR do?

  • Create all the appropriate ECR bits for a new containerized Python application
  • Add checkov skips for encryption warnings about ssm_outputs

Side effects of this change:
None.

Helpful background context

Enterprise Systems is working on a new bursar transfer application that integrates with Alma.

What are the relevant tickets?

Requires Database Migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:
Enterprise Systems is working on a new bursar transfer application that
integrates with Alma.

How this addresses that need:
* Create all the appropriate ECR bits for a new containerized
Python application
* Add checkov skips for encryption warnings about ssm_outputs

Side effects of this change:
None.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/ENSY-177
@cabutlermit cabutlermit requested review from a team and adamshire123 August 2, 2023 17:54
@cabutlermit
Copy link
Contributor Author

@adamshire123 I don't need your approval of this -- just a head's up that this is getting queued up (it's only the creation of the ECR repository and the associated GitHub Actions publishing workflows for your application)

Copy link

@adamshire123 adamshire123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm commenting mainly to give this a bump, in case it needed a bump. I don't know TF well enough to approve these changes.

@cabutlermit cabutlermit self-assigned this Aug 31, 2023
@cabutlermit cabutlermit requested review from a team and removed request for a team August 31, 2023 14:36
Copy link
Contributor

@tim-rix tim-rix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK to me

Copy link
Contributor

@vab vab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cabutlermit cabutlermit merged commit 1774d33 into stage Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants