Skip to content

Conversation

ghukill
Copy link
Contributor

@ghukill ghukill commented Mar 19, 2025

Purpose and background context

Initial project scaffolding, using the name validator for internal packages as the code is geared around being an S3 Bagit bag "validator".

At this point, just a renaming and dependencies update.

How can a reviewer manually see the effects of these changes?

Nothing to see yet, but make test and make lint are successful.

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

@ghukill ghukill marked this pull request as ready for review March 19, 2025 13:07
@ghukill ghukill requested a review from a team March 19, 2025 13:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13947461005

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 13923858138: 0.0%
Covered Lines: 18
Relevant Lines: 18

💛 - Coveralls

@ghukill ghukill merged commit 5161f69 into main Mar 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants