Ir 233 validate all #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * Add CLI command to validate all AIPs in a given AWS environment How this addresses that need: * Add validate-all CLI command and corresponding CLI test * Add logging statement to bulk-validate CLI command and update corresponding CLI tests Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IR-233
ghukill
requested changes
May 7, 2025
* Add bulk-validate args to validate-all * Remove unnecessary .seek() call
Pull Request Test Coverage Report for Build 14891726606Details
💛 - Coveralls |
ehanson8
added a commit
that referenced
this pull request
May 9, 2025
* Add pip-audit and update dependencies * IR-233 validate all Why these changes are being introduced: * Add CLI command to validate all AIPs in a given AWS environment How this addresses that need: * Add validate-all CLI command and corresponding CLI test * Add logging statement to bulk-validate CLI command and update corresponding CLI tests Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IR-233 * Updates based on discussion in PR # 96 * Add bulk-validate args to validate-all * Remove unnecessary .seek() call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Add command to validate all AIPs in the current AWS environment.
Includes recent
pip-auditupdates.How can a reviewer manually see the effects of these changes?
Set credentials for
Dev,Stage, orProdand run the following command:Observe app's logging statements and verify that the
validate_all.csvis created and populated.Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)