Skip to content

TIMX 540 - adjust AWS credential chain for ECS context #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

TIMX 540 - adjust AWS credential chain for ECS context #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fc088d
Install HTTPFS extension in DuckDB context
ghukill Aug 14, 2025
5b56965
Omit chain from DuckDB S3 secret
ghukill Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion timdex_dataset_api/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,14 @@ def _configure_duckdb_s3_secret(
If a scope is provided, e.g. an S3 URI prefix like 's3://timdex', set a scope
parameter in the config. Else, leave it blank.
"""
# install httpfs extension
conn.execute(
"""
install httpfs;
load httpfs;
"""
)

# establish scope string
scope_str = f", scope '{scope}'" if scope else ""

Expand All @@ -186,7 +194,6 @@ def _configure_duckdb_s3_secret(
create or replace secret aws_s3_secret (
type s3,
provider credential_chain,
chain 'sso;env;config',
Copy link
Contributor Author

@ghukill ghukill Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This here was the key change.

refresh true
{scope_str}
);
Expand Down