TIMX-559 - Pin duckdb to 1.4.2-dev27 #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: Previously, we had to pin our duckdb version to <1.4 as the 1.4 release had a couple of temporary breaking changes. Once 1.4.1 was released we tried unpinning, but found a new breaking change. This was again determined temporary after some duckdb issues discussions, indicating that a 1.4.2 release will fix this bug. In both cases they were bugs with the release. It is believed that the 1.4 release is a big one for duckdb, so a bit more churn that normal. That said, development is rapid on the TIMDEX ETL pipeline at the moment, and this library, and continuing to work with the newest version of duckdb is desirable. A 1.4.2 release will likely be soon, but we don't know when. How this addresses that need: Updates duckdb pinned version to 1.4.2.dev27, which is confirmed to work for us. Once 1.4.2 is released, we can remove this pin. Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-559
Pull Request Test Coverage Report for Build 18594880427Details
💛 - Coveralls |
ehanson8
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Why these changes are being introduced:
Previously, we had to pin our duckdb version to
<1.4as the1.4release had a couple of temporary breaking changes. Once1.4.1was released we tried unpinning, but found a new breaking change. This was again determined temporary after some duckdb issues discussions, indicating that a1.4.2release will fix this bug.See this
duckdbissue for more context and confirmation that1.4.2.dev27works: duckdb/duckdb-python#126 (comment).In both cases they were bugs with the release. It is believed that the
1.4release is a big one for duckdb, so a bit more churn that normal.That said, development is rapid on the TIMDEX ETL pipeline at the moment, and this library, and continuing to work with the newest version of duckdb is desirable. A
1.4.2release will likely be soon, but we don't know when.How this addresses that need:
Updates duckdb pinned version to
1.4.2.dev27, which is confirmed to work for us. Once1.4.2is released, we can remove this pin.How can a reviewer manually see the effects of these changes?
Working tests are confirmation that
1.4.2.dev27is sufficient. Both1.4.0and1.4.1have different errors that crop up during unit tests.Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?