Skip to content

Conversation

@ghukill
Copy link
Contributor

@ghukill ghukill commented Nov 18, 2025

Purpose and background context

Small PR to allow None for both embedding_vector and embedding_object in the DatasetEmbedding dataclass.

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

@ghukill ghukill requested a review from a team November 18, 2025 21:37
@jonavellecuerdo
Copy link
Contributor

Oh, should TIMDEXEmbeddings be imported like:

from timdex_dataset_api import TIMDEXEmbeddings

? If so, then please also update: https://github.com/MITLibraries/timdex-dataset-api/blob/USE-142-dataset-embedding-types/timdex_dataset_api/__init__.py. 🤓

@ghukill
Copy link
Contributor Author

ghukill commented Nov 18, 2025

Oh, should TIMDEXEmbeddings be imported like:

from timdex_dataset_api import TIMDEXEmbeddings

? If so, then please also update: https://github.com/MITLibraries/timdex-dataset-api/blob/USE-142-dataset-embedding-types/timdex_dataset_api/__init__.py. 🤓

Good call! Commit forthcoming.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19481805362

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.79%

Totals Coverage Status
Change from base Build 19472238764: 0.01%
Covered Lines: 589
Relevant Lines: 628

💛 - Coveralls

@ghukill ghukill merged commit 3161b36 into main Nov 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants