TIMX 496 - Update TDA and all dependencies #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: The TDA library is a Github dependency in the Pipefile, but the normal `pipenv update --dev` does not pickup versions bumps in the TDA library. However, an explicit `pipenv update <TDA_URL>` will. How this addresses that need: * Adds an explicit TDA update in the `make update` command Side effects of this change: * TDA is updated to v2.0 (current) Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-496
ghukill
force-pushed
the
TIMX-496-update-tda
branch
from
16199f5 to
be9ce95
Compare
ehanson8
approved these changes
Jun 3, 2025
Pull Request Test Coverage Report for Build 15423664672Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
This PR updates the TDA library, and all dependencies while at it.
This is achieved by updating the
make updatecommand to explicitly update the TDA library. This is not achieved bypipenv update --devdespite it being a dependency in thePipfile.There may be alternate approaches for the installation, versioning, and updating of local libraries from Git...but this feels like a pretty workable solution for the time being: one line in the
Makefileensures that TDA is updated alongside all other libraries.FWIW, I would propose that our (hopeful) switch to
uvwould be a good time to revisit this approach, if we'd like to.How can a reviewer manually see the effects of these changes?
Manual testing is not terribly convenient for the pipeline lambda, but there are no plans for it to use the new
run_timestampcolumn for any reads.Includes new or updated dependencies?
YES: bumps
timex-dataset-apitov.2.0(current version)Changes expectations for external applications?
YES: any read/writes to the dataset will include the
run_timestampcolumn nowWhat are the relevant tickets?
Developer
Code Reviewer(s)