Merge pull request #307 from MITLibraries/use-232-libkey

Integrate Libkey with results UI

Author: matt-bernhardt

app/models/normalize_primo_record.rb

@@ -18,6 +18,8 @@ def normalize
       links:,
       citation:,
       identifier:,
+      doi:,
+      pmid:,
       summary:,
       publisher:,
       location:,
@@ -142,6 +144,30 @@ def identifier
     @record['pnx']['control']['recordid'].join
   end
 
+  def doi
+    return unless @record['pnx']['addata'] && @record['pnx']['addata']['doi']
+
+    if @record['pnx']['addata']['doi'].length > 1
+      Sentry.set_tags('mitlib.recordId': identifier || 'empty record id')
+      Sentry.set_tags('mitlib.dois': @record['pnx']['addata']['doi'])
+      Sentry.capture_message('Multiple DOIs found in one record')
+    end
+
+    @record['pnx']['addata']['doi'].first
+  end
+
+  def pmid
+    return unless @record['pnx']['addata'] && @record['pnx']['addata']['pmid']
+
+    if @record['pnx']['addata']['pmid'].length > 1
+      Sentry.set_tags('mitlib.recordId': identifier || 'empty record id')
+      Sentry.set_tags('mitlib.pmids': @record['pnx']['addata']['pmid'])
+      Sentry.capture_message('Multiple PMIDs found in one record')
+    end
+
+    @record['pnx']['addata']['pmid'].first
+  end
+
   def summary
     return unless @record['pnx']['display']['description']
 

app/views/libkey/lookup.html.erb

@@ -1,3 +1,3 @@
 <% if Libkey.enabled? && @libkey.present? %>
-  <%= link_to( @libkey[:text], @libkey[:link], class: 'button button-primary' ) %>
+  <%= link_to( @libkey[:text], @libkey[:link], class: 'button', style: 'border: none;' ) %>
 <% end %>

app/views/search/_result_primo.html.erb

@@ -40,6 +40,11 @@
           <%= link_to link['kind'].titleize, link['url'], class: 'button' %>
         <% end %>
       <% end %>
+      <% if Libkey.enabled? && result[:doi].present? %>
+        <%= render(partial: 'trigger_libkey', locals: { kind: 'doi', identifier: result[:doi] }) %>
+      <% elsif Libkey.enabled? && result[:pmid].present? %>
+        <%= render(partial: 'trigger_libkey', locals: { kind: 'pmid', identifier: result[:pmid] }) %>
+      <% end %>
       <% if result[:availability].present? %>
         <span class="availability"><%= availability(result[:availability], result[:location], result[:other_availability]) %></span>
       <% end %>

app/views/search/_trigger_libkey.html.erb

@@ -0,0 +1,14 @@
+<% return unless Libkey.enabled? %>
+
+<% data_url = "/lookup?type=#{kind}&identifier=#{identifier}" %>
+
+<span class="tacos-container"
+     data-controller="content-loader"
+     data-content-loader-url-value=<%= data_url %>>
+     <span style="background-color:lightgray;
+                  display: inline-block;
+                  font-size: 1.6rem;
+                  font-weight: 500;
+                  margin-right: 16px;
+                  min-width: 120px;">&nbsp;</span>
+</span>

test/controllers/libkey_controller_test.rb

@@ -27,14 +27,14 @@ class LibkeyControllerTest < ActionDispatch::IntegrationTest
       get '/lookup?type=doi&identifier=10.1038/s41567-023-02305-y'
 
       assert_response :success
-      assert_select 'a.button-primary', { count: 1 }
+      assert_select 'a.button', { count: 1 }
     end
 
     VCR.use_cassette('libkey pmid') do
       get '/lookup?type=pmid&identifier=22110403'
 
       assert_response :success
-      assert_select 'a.button-primary', { count: 1 }
+      assert_select 'a.button', { count: 1 }
     end
   end
 

test/fixtures/primo/full_record.json

@@ -17,7 +17,9 @@
       "pages": ["123-145"],
       "jtitle": ["Journal of Testing"],
       "isbn": ["9781234567890", "1234567890"],
-      "pub": ["MIT Press"]
+      "pub": ["MIT Press"],
+      "doi": ["10.1038/s41567-023-02305-y"],
+      "pmid": ["22110403"]
     },
     "facets": {
       "frbrtype": ["5"],

test/models/normalize_primo_record_test.rb

@@ -106,6 +106,44 @@ def cdi_record
     assert_equal 'alma991000000001234567', normalized[:identifier]
   end
 
+  test 'normalizes doi' do
+    normalized = NormalizePrimoRecord.new(full_record, 'test').normalize
+    assert_equal normalized[:doi], '10.1038/s41567-023-02305-y'
+  end
+
+  test 'handles missing doi' do
+    normalized = NormalizePrimoRecord.new(minimal_record, 'test').normalize
+    assert_nil normalized[:doi]
+  end
+
+  test 'multiple dois normalize to the first one' do
+    temp_record = full_record
+    temp_record['pnx']['addata']['doi'] = %w[three two one]
+
+    normalized = NormalizePrimoRecord.new(temp_record, 'test').normalize
+
+    assert_equal normalized[:doi], 'three'
+  end
+
+  test 'normalizes pmid' do
+    normalized = NormalizePrimoRecord.new(full_record, 'test').normalize
+    assert_equal normalized[:pmid], '22110403'
+  end
+
+  test 'handles missing pmid' do
+    normalized = NormalizePrimoRecord.new(minimal_record, 'test').normalize
+    assert_nil normalized[:pmid]
+  end
+
+  test 'multiple pmids normalize to the first one' do
+    temp_record = full_record
+    temp_record['pnx']['addata']['pmid'] = %w[three two one]
+
+    normalized = NormalizePrimoRecord.new(temp_record, 'test').normalize
+
+    assert_equal normalized[:pmid], 'three'
+  end
+
   test 'normalizes summary' do
     normalized = NormalizePrimoRecord.new(full_record, 'test').normalize
     assert_equal 'A comprehensive study of testing methodologies', normalized[:summary]