Render separate results partial for GeoData #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
As USE and GeoData continue to diverge, it makes
less sense for them to share view partials. This
became clear when the USE tabbed results view
broke GeoData full record view due to its
implementation of Turbo frames. To fix this
problem in the same results view would require an
even more complex map of forked logic than we
already had in that view.
Relevant ticket(s):
How this addresses that need:
This adds a separate
results_geo
partial thatis rendered when the GeoData feature flag is
active.
Side effects of this change:
search_summary
partial has been renamed tosearch_summary_geo
, andsearch_summary_use
has been renamed to
search_summary
. This bettermatches our naming conventions for forked views.
result_primo
tidies upa link.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
Please check with and without the
GDT
env variable. WhenGDT
is present, click through to a full record to ensure that it loads properly.Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing