Skip to content

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Oct 8, 2025

Why these changes are being introduced:

As USE and GeoData continue to diverge, it makes
less sense for them to share view partials. This
became clear when the USE tabbed results view
broke GeoData full record view due to its
implementation of Turbo frames. To fix this
problem in the same results view would require an
even more complex map of forked logic than we
already had in that view.

Relevant ticket(s):

How this addresses that need:

This adds a separate results_geo partial that
is rendered when the GeoData feature flag is
active.

Side effects of this change:

  • Forked views are something we've tried to avoid, but in this case it felt like the least bad option.
  • The search_summary partial has been renamed to search_summary_geo, and search_summary_use
    has been renamed to search_summary. This better
    matches our naming conventions for forked views.
  • An runelated change to result_primo tidies up
    a link.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

Please check with and without the GDT env variable. When GDT is present, click through to a full record to ensure that it loads properly.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Oct 8, 2025

Pull Request Test Coverage Report for Build 18356464837

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.246%

Totals Coverage Status
Change from base Build 18353787399: 0.002%
Covered Lines: 840
Relevant Lines: 855

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-full-recor-buoduk October 8, 2025 19:43 Inactive
@jazairi jazairi temporarily deployed to timdex-ui-pi-full-recor-buoduk October 8, 2025 19:52 Inactive
@jazairi jazairi temporarily deployed to timdex-ui-pi-full-recor-buoduk October 8, 2025 19:53 Inactive
Why these changes are being introduced:

As USE and GeoData continue to diverge, it makes
less sense for them to share view partials. This
became clear when the USE tabbed results view
broke GeoData full record view due to its
implementation of Turbo frames. To fix this
problem in the same results view would require an
even more complex map of forked logic than we
already had in that view.

Relevant ticket(s):

* [USE-31](https://mitlibraries.atlassian.net/browse/USE-31)

How this addresses that need:

This adds a separate `results_geo` partial that
is rendered when the GeoData feature flag is
active.

Side effects of this change:

* Forked views are something we've tried to avoid,
but in this case it felt like the least bad option.
* The `search_summary` partial has been renamed
to `search_summary_geo`, and `search_summary_use`
has been renamed to `search_summary`. This better
matches our naming conventions for forked views.
* An runelated change to `result_primo` tidies up
a link.
@jazairi jazairi force-pushed the full-record-bugfix branch from ef20fcf to 12d92f5 Compare October 8, 2025 19:57
@jazairi jazairi temporarily deployed to timdex-ui-pi-full-recor-buoduk October 8, 2025 19:57 Inactive
@jazairi jazairi marked this pull request as ready for review October 8, 2025 20:05
@jazairi jazairi requested a review from JPrevost October 8, 2025 20:24
@jazairi jazairi requested a review from matt-bernhardt October 8, 2025 20:24
@JPrevost JPrevost self-assigned this Oct 9, 2025
Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll with this for now as I'm confident we'll have a lot of churn on these files as we build out the app and it will be easier to bring things back together later once we have a better feel what the end state looks like.

@jazairi jazairi merged commit b6ed2bf into main Oct 9, 2025
5 checks passed
@jazairi jazairi deleted the full-record-bugfix branch October 9, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants