Skip to content

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Oct 9, 2025

This was an interesting idea, but it wasn't triggering enough for to warrant the frustration the upgrade process caused when the gem entirely changed under the hood. I'm sure it made sense, but it was easier to remove it than update the configs to work on newer versions. We may bring it back eventually if it stabilizes or our needs warrant it.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
  • ENV has been REMOVED from README
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Oct 9, 2025

Pull Request Test Coverage Report for Build 18377963873

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 98.242%

Totals Coverage Status
Change from base Build 18377781275: -0.004%
Covered Lines: 838
Relevant Lines: 853

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-timx-565-d-bsbnxc October 9, 2025 12:54 Inactive
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance!

This was an interesting idea, but it wasn't triggering enough for to warrant the frustration the upgrade process caused when the gem entirely changed under the hood. I'm sure it made sense, but it was easier to remove it than update the configs to work on newer versions. We may bring it back eventually if it stabilizes or our needs warrant it.
@JPrevost JPrevost force-pushed the timx-565-depupdates branch from 5a2863e to 7f4d294 Compare October 9, 2025 13:28
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-timx-565-d-bsbnxc October 9, 2025 13:29 Inactive
@JPrevost JPrevost merged commit a4922a2 into main Oct 9, 2025
5 checks passed
@JPrevost JPrevost deleted the timx-565-depupdates branch October 9, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants