Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The Primo API performs poorly. We should do what
we can to mitigate this.
Relevant ticket(s):
How this addresses that need:
This adds caching to Primo queries.
Side effects of this change:
None, but it's worth noting that we experience
many unique searches, and this will only help
with latency if USE UI has seen the query before.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
You can toggle caching locally by running
rails dev:cache
. It might be useful to compare load times between your local (or this PR build) and another app without Primo caching enabled, such as staging.Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing