Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Oct 22, 2025

Developer

In a recent update to the USE UI header, we introduced a new navigation component and moved the local nav links into this element.

GeoData had conditional links with custom markup, and the custom markup was causing visual bugs in the navigation.

This work removes that custom markup, effectively appending the conditional GeoData links to the end of the link list.

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@djanelle-mit djanelle-mit changed the title Removed unneeded markup from GeoData links in navigation USE-123 - Removed unneeded markup from GeoData links in navigation Oct 22, 2025
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-128-kgvl6nvg7 October 22, 2025 13:30 Inactive
@JPrevost JPrevost self-assigned this Oct 22, 2025
@djanelle-mit djanelle-mit merged commit 4efba2c into main Oct 22, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-128 branch October 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants