Skip to content

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Oct 24, 2025

  • Removes FlipFlop Gem
  • Updates code and tests to use Feature class instead of FlipFlip
  • Stabilizes test suite

Side effects:

  • Moved some geo tests to their own file to match other similar tests
  • Updated some tests that had a condition in them that should never occur
  • GeoData stage and prod have had FEATURE_GEODATA=true added to config. We can remove GDT=true after this is deployed

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-77-rem-qyqv6t October 24, 2025 12:15 Inactive
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-77-rem-qyqv6t October 24, 2025 12:55 Inactive
@jazairi jazairi self-assigned this Oct 24, 2025
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've ever been happier to approve a PR. :) Thanks for figuring this out and dealing with the slog of replacing FlipFlop in all of the tests!

I did have one question about the GeoData feature name in the README. If it actually is FEATURE_GDT, then I think this is ready to merge. If not, then fixing that is the only issue I see here.

@JPrevost JPrevost force-pushed the use-77-remove-flipflip branch from f489ddc to a15478d Compare October 24, 2025 15:08
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-77-rem-qyqv6t October 24, 2025 15:09 Inactive
@JPrevost JPrevost merged commit 22f5b1c into main Oct 24, 2025
5 checks passed
@JPrevost JPrevost deleted the use-77-remove-flipflip branch October 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants