Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Nov 10, 2025

Developer

After implementing the search box section of our header, the h3 that was acting as a label to the search box wasn't connected to the input mechanically or from an accessibility standpoint.

This work replaces that h3 with a label and uses the for attribute to get both built-in behavior and accessibility benefits.

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-151-el0r2amoa November 10, 2025 17:53 Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19240945681

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.865%

Totals Coverage Status
Change from base Build 19240682764: 0.0%
Covered Lines: 871
Relevant Lines: 890

💛 - Coveralls

@JPrevost JPrevost self-assigned this Nov 10, 2025
@djanelle-mit djanelle-mit merged commit e0eadf1 into main Nov 10, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-151 branch November 10, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants