USE-61: Added page title with results count and description of source to USE UI

[djanelle-mit]

Developer

As part of the visual design for USE UI we decided to have the title of the page reflect the count of results, and have a line of text below it describing what is contained in that set of results. This PR implements that title and description, as well as makes relevant style changes to layout and typography to accommodate this.

This work includes:

• Adding new static description text below results count title
• Overriding theme gem styles for existing elements
• Removing logic to the old site title shared between USE and GEO
• Removing logic and partial for the "you searched for" text
• Fixing typography color bugs (including overriding some theme gem rules)
• Adjusting spacing between page containers, title, description, and suggested resources when present.

This work does NOT include:

• Dynamically updating the results description to match the selected tab. I'll create a ticket for that work.

Accessibility

• ANDI or WAVE has been run in accordance to our guide.
• This PR contains no changes to the view layer.
• New issues flagged by ANDI or WAVE have been resolved.
• New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
• No new accessibility issues have been flagged.

New ENV

• All new ENV is documented in README.
• All new ENV has been added to Heroku Pipeline, Staging and Prod.
• ENV has not changed.

Approval beyond code review

• UXWS/stakeholder approval has been confirmed.
• UXWS/stakeholder review will be completed retroactively.
• UXWS/stakeholder review is not needed.

Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code

• I have confirmed that the code works as intended.
• Any CodeClimate issues have been fixed or confirmed as
  added technical debt.

Documentation

• The commit message is clear and follows our guidelines
  (not just this pull request message).
• The documentation has been updated or is unnecessary.
• New dependencies are appropriate or there were no changes.

Testing

• There are appropriate tests covering any new functionality.
• No additional test coverage is required.

[djanelle-mit]

Note for reviewer: It looks like the failing test is this one, but would love confirmation on that and tips on how to proceed, testing like this is completely new to me.

test 'results uses simplified search summary for USE app' do
mock_primo_search_success

get '/results?q=test'
assert_response :success
assert_select 'aside.search-summary', count: 1
assert_select 'aside.search-summary', text: /You searched for: test/

end

search_controller_test line 621

[coveralls]

Pull Request Test Coverage Report for Build 19301578737

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.865%

---

Totals
Change from base Build 19241636129:	0.0%
Covered Lines:	871
Relevant Lines:	890

---

💛 - Coveralls

[JPrevost]

When you open a ticket to update the text based on the selected tab, can you add to the success criteria that we add tests? I updated the existing tests to look for the "all tab" text as that is currently hard coded so we should either remove that or add tests that ensure we end in the correct state for each tab as expected when implemented.