Skip to content

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Dec 1, 2025

Example search: A review on mixed mode fracture of metals in this branch versus in main will show different results. The results introduced in this PR match the expectations of stakeholders and can be confirmed using Primo UI.

Why are these changes being introduced:

  • Results from Primo should include things we do not subscribe to so users can find and request them

Relevant ticket(s):

How does this address that need:

  • Adds the pcAvailability=true parameter to Primo search requests

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why are these changes being introduced:

* Results from Primo should include things we do not subscribe to so
  users can find and request them

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-233

How does this address that need:

* Adds the pcAvailability=true parameter to Primo search requests
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19835970485

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.833%

Totals Coverage Status
Change from base Build 19828164303: 0.0%
Covered Lines: 948
Relevant Lines: 969

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-233-se-ego1pi December 1, 2025 20:10 Inactive
@jazairi jazairi self-assigned this Dec 1, 2025
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to finish this review yesterday! Confirmed different results display in this PR for the test query provided. I notice we're hardcoding the value of pcAvailability, but that feels okay to me because I doubt we'd ever want it to be false.

@JPrevost JPrevost merged commit 742fe3a into main Dec 2, 2025
5 checks passed
@JPrevost JPrevost deleted the use-233-search-beyond branch December 2, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants