Fix clean_term (including double quotes)

[JPrevost]

Why are these changes being introduced:

• Double quotes were breaking searches

Relevant ticket(s):

• https://mitlibraries.atlassian.net/browse/USE-237

How does this address that need:

• Updates our clean_term method in the Primo model to use URI.encode_www_form_component instead of our bespoke logic

Document any side effects to this change:

• I believe this fixes some unreported issues with our clean_term method. We replaced a few characters with + and did some very odd things with ++ (likley to "help" with searching for c++) that seem to have been making things worse not better. Using the form encoding method seems to handle those types of searches much more in line with how Primo UI works.

Developer

Accessibility

• ANDI or WAVE has been run in accordance to our guide.
• This PR contains no changes to the view layer.
• New issues flagged by ANDI or WAVE have been resolved.
• New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
• No new accessibility issues have been flagged.

New ENV

• All new ENV is documented in README.
• All new ENV has been added to Heroku Pipeline, Staging and Prod.
• ENV has not changed.

Approval beyond code review

• UXWS/stakeholder approval has been confirmed.
• UXWS/stakeholder review will be completed retroactively.
• UXWS/stakeholder review is not needed.

Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code

• I have confirmed that the code works as intended.
• Any CodeClimate issues have been fixed or confirmed as
  added technical debt.

Documentation

• The commit message is clear and follows our guidelines
  (not just this pull request message).
• The documentation has been updated or is unnecessary.
• New dependencies are appropriate or there were no changes.

Testing

• There are appropriate tests covering any new functionality.
• No additional test coverage is required.

[coveralls]

Pull Request Test Coverage Report for Build 19940776314

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.883%

---

Totals
Change from base Build 19940736603:	0.0%
Covered Lines:	971
Relevant Lines:	992

---

💛 - Coveralls

[jazairi]

Much better. 🙂