Skip to content

Conversation

@JPrevost
Copy link
Member

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib mitlib temporarily deployed to timdex-ui-pi-bugfix-d5epxf9pk1 July 12, 2022 18:44 Inactive
@coveralls
Copy link

coveralls commented Jul 12, 2022

Pull Request Test Coverage Report for Build dee86b84a4e5db7431b8e973deec569fe51456e4-PR-61

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.408%

Totals Coverage Status
Change from base Build df7668144697776d4ed226fd3e004bf79ad43cf5: 0.0%
Covered Lines: 336
Relevant Lines: 338

💛 - Coveralls

@JPrevost JPrevost merged commit dfa0f1b into main Jul 12, 2022
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me...

:shipit:

@JPrevost JPrevost deleted the bugfix branch October 1, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants