Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Aug 1, 2022

Why these changes are being introduced:

The record view does not join the content type field on a character,
so multiple content types are displayed in an unreadable format.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/RDI-242

How this addresses that need:

This joins the content type field on a semicolon to render it
the same as the result view.

Side effects of this change:

None.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

The record view does not join the content type field on a character,
so multiple content types are displayed in an unreadable format.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/RDI-242

How this addresses that need:

This joins the content type field on a semicolon to render it
the same as the result view.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to timdex-ui-pi-rdi-242-co-hbk1c1 August 1, 2022 18:53 Inactive
@coveralls
Copy link

coveralls commented Aug 1, 2022

Pull Request Test Coverage Report for Build bd10cfba2f5d37043b8b51360649187e15e52769-PR-70

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.42%

Totals Coverage Status
Change from base Build 41719d2afe149ed79ad511ec19f96f73aed98505: 0.0%
Covered Lines: 343
Relevant Lines: 345

💛 - Coveralls

@jazairi jazairi requested a review from JPrevost August 1, 2022 18:56
@jazairi jazairi merged commit 5590545 into main Aug 2, 2022
@jazairi jazairi deleted the rdi-242-content-types-bug branch August 2, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants