Adds GitHub Actions #265
Merged
Adds GitHub Actions #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: - Adds simplecov and simplecov-lcov gems - Removes coveralls gem - Removes .travis.yml - Adjusts test_helper accordingly
matt-bernhardt
force-pushed
the
engx-1-github-actions
branch
from
45f1ad8 to
f33ec10
Compare
matt-bernhardt
requested review from
JPrevost and
jazairi
and removed request for
jazairi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This follows the instructions at https://mitlibraries.github.io/guides/languages/rails.html#continuous-integration
Helpful background context
This is part of a suite of changes to our Rails apps as we start adopting GitHub Actions.
How can a reviewer manually see the effects of these changes?
You should see GitHub actions running as part of this PR, with the appropriate (unchanged) amount of tests and test coverage.
What are the relevant tickets?
Requires Database Migrations?
NO (I think?)
Includes new or updated dependencies?
YES (adds simplecov and simplecov-lcov)