Update dependencies #329
Merged
Update dependencies #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump jwt from 2.2.1 to 2.2.2 Bump simplecov from 0.18.5 to 0.19.0 Bump graphql from 1.11.1 to 1.11.3 Bump bootsnap from 1.4.6 to 1.4.8 Bump rubocop from 0.88.0 to 0.89.1 Bump rubocop-rails from 2.6.0 to 2.7.1
matt-bernhardt
approved these changes
Aug 20, 2020
Member
matt-bernhardt
left a comment
matt-bernhardt
left a comment
There was a problem hiding this comment.
I see the test coverage stayed the same, and all tests pass. Looking down the list of gems that are getting updated, I did the following manual checks:
- Poked on the GraphQL playground (saw that it still worked as expected)
- Noted that our tooling was still functioning, so rubocop and simplecov should be good
- Registered with the review application and went through the authorizations Curl example to make sure JWT worked as expected
- Noted what the web app performance was (which seems reasonable for a sign of life from Bootsnap)
Based on this, I think we're good for 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates several dependencies:
Requires Database Migrations?
NO
Includes new or updated dependencies?
YES