Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Aug 9, 2022

Why these changes are being introduced:

Sentry now prefers the sentry-ruby/sentry-rails gems and has
deprecated sentry-raven.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ENGX-88

How this addresses that need:

This removes sentry-raven and adds sentry-ruby and sentry-rails,
including the required initializer.

Side effects of this change:

None.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to timdex-pr-558 August 9, 2022 19:23 Inactive
Why these changes are being introduced:

Sentry now prefers the sentry-ruby/sentry-rails gems and has
deprecated sentry-raven.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ENGX-88

How this addresses that need:

This removes sentry-raven and adds sentry-ruby and sentry-rails,
including the required initializer.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to timdex-pr-558 August 9, 2022 19:34 Inactive
@jazairi
Copy link
Contributor Author

jazairi commented Aug 9, 2022

Here's an example of the app sending errors to Sentry: https://sentry.io/organizations/mit-libraries/issues/3229789786/?project=2217771&query=is%3Aunresolved

@JPrevost JPrevost self-assigned this Aug 9, 2022
Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jazairi jazairi merged commit 5e313c2 into main Aug 9, 2022
@jazairi jazairi deleted the upgrade-sentry branch August 9, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants