Rename *Facet arguments to *Filter #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: 'Filter' more accurately describes our facet arguments. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-177 How this addresses that need: This renames all 'facet' arguments to use 'filter' instead. Side effects of this change: TIMDEX UI will need to be updated in conjunction with this code merging.
jazairi
force-pushed
the
timx-177-facets-to-filters
branch
from
3aa142d to
ec5ccea
Compare
9 tasks
JPrevost
reviewed
Feb 6, 2023
Member
JPrevost
left a comment
JPrevost
left a comment
There was a problem hiding this comment.
This looks good to go. Holding off on approval only until we can be prepared to merge this, merge the UI work, and then launch them together-ish.
JPrevost
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
'Filter' more accurately describes our facet arguments.
Relevant ticket(s):
How this addresses that need:
This renames all 'facet' arguments to use 'filter' instead.
Side effects of this change:
TIMDEX UI will need to be updated in conjunction with this code merging.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO