Skip to content
This repository was archived by the owner on Oct 24, 2022. It is now read-only.

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Jun 4, 2015

This is starting to get a bit messy, but I think this ends the work in this general area so maybe it's okay.

closes #214

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 53.1% when pulling f5d5a59 on 214_non_oai_returned_at_harvest into 36af447 on master.

@richardrodgers
Copy link
Collaborator

Yea, I'm not wild about all that counter/break stuff - but I guess we can refactor later
👍

@JPrevost
Copy link
Member Author

JPrevost commented Jun 5, 2015

Yeah, it's definitely a bit of code smelly (to be generous) as is but I didn't have an immediate better idea of how to detect a valid OAI-PMH XML file without switching to a DOM parsing model. Like you said, we can come back and refactor if/when one of us has a better idea or if we notice this falling apart in real world scenarios.

JPrevost added a commit that referenced this pull request Jun 5, 2015
…vest

Handle non-oai response during Harvest
@JPrevost JPrevost merged commit ecf4ee0 into master Jun 5, 2015
@JPrevost JPrevost deleted the 214_non_oai_returned_at_harvest branch June 5, 2015 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle non-OAI response during initial Harvest

4 participants