This repository was archived by the owner on Oct 24, 2022. It is now read-only.
Detects and does very little with Cataloger Errors #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a start towards catching exceptions in the Cataloger. Determining what we want to do seems important here.
JPrevost
added a commit
that referenced
this pull request
Jul 13, 2015
Detects and does very little with Cataloger Errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start towards catching exceptions in the Cataloger.
Determining what we want to do seems important here.
Thoughts on how to proceed are welcome. Mine are mostly that it would be good to catch more specific Exceptions when possible and fallback on the generic Exception only as a last resort... but as I'm not sure if we'll handle the different exceptions differently, I'm not sure if that makes it clearer or muddier.
see #211