Backend api test dev #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loriab
approved these changes
Mar 10, 2025
Collaborator
loriab
left a comment
loriab
left a comment
There was a problem hiding this comment.
I do think the import name should change, but it's up to you.
| import unittest | ||
| from grid2op.tests.aaa_test_backend_interface import AAATestBackendAPI | ||
|
|
||
| from PandaModelsBackend import PandaModelsBackend |
Collaborator
There was a problem hiding this comment.
Ok for the repo name and the class name to be camelcase, but shouldn't the import name be lowercase? https://peps.python.org/pep-0008/#package-and-module-names
|
|
||
| # The following tests are skipped as these tests may not relevant for the PandaModelsBackend backend | ||
| # in the PandaModelsBackend as PandaPower runnpp doesn't converge but runpm does | ||
| def test_17_isolated_gen_stops_computation(self): |
Collaborator
There was a problem hiding this comment.
would @unittest.expectedFailure be relevant? https://docs.python.org/3/library/unittest.html#skipping-tests-and-expected-failures it says it's only for failures in the assert, not for failures at RT, so maybe not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented and added AAA Backend tests to check the backend API. There are total 5 tests that are skipped: