UPDATE : Development to Master #2338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [UPDATED] Cronjobs to store real values, display with coin precision * [UPDATED] Templates to use new coin precision setting in dashboard * [UPDATED] JS API calls to use new precision setting too * [UPDATED] PPS Value is displayed as coin precision + 8 This should help with #2216 and address issues with coins where rounding of 12 was not enough.
This reverts commit b987358.
This reverts commit 1a3d5e6.
* [ADDED] New option to coin class to change coin value precision * [UPDATE] SQL Transactions table from double to decimal(50,30) * [REMOVED] Admin setting for coin value precision * [UPDATE] JS files to honor coin precision
* Allow users to define a seperate mobile template
* Defaults to bootstrap
* Disconnects desktop sites from mobile sites
Fixes #2329 once merged
Mobile detection
Coin rounding setting
TheSerapher
added a commit
that referenced
this pull request
Oct 14, 2014
UPDATE : Development to Master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future merge from Development to Master. Find a detailed changelog here and hints and tips on upgrading this specific release.
Changelog
Mobile Detection
We always had mobile detection in Bootstrap but decided to re-add the ability for admins to specific different templates for desktop and mobile devices. This will allow you to setup your own theme for desktop but keep the existing bootstrap one for mobile systems. You can focus on Desktop development while keeping the functionality supplied by our default bootstrap theme.
Long time users that have been running MPOS prior to the bootstrap merge may have to save their settings in the Admin Panel once again to save the new default value for the mobile template. Otherwise you will get a 'could not load master.tpl' error when browsing to the site with a mobile device.
Coin Rounding Precision
You can now adjust the precision for each coins pay calculations! Before this change, all payouts were fixed to 8 digits after the decimal point. From now on, the default setting is 8 digits as before, but as a first adjustment we have added a precision of 20 to all sha256d coins. Many of these have very high difficulties and often users only get paid a fraction of the total blocks value. This is especially true when running PPS (not recommended) for high difficulty coins.
You don't need to change anything on your end for this to work, but you can adjust the precision by changing the coin class of your choice and adding this (sample from SHA256d): https://github.com/MPOS/php-mpos/blob/development/include/classes/coins/coin_sha256d.class.php#L11
This will update all payout processing and display values on the website to use that precision instead.