Fix SQL in cleaning up old notifications #2665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtracting numbers from datetime causes wrong value, or raises error depending on MySQL version/configurations. It leads deleting notification wrongly or failed to do so.
This PR solves above issue by using
INTERVAL
to make appropriate value for date calculation.Below confimed in MySQL8.0
The result
20180100527811
is wrong. It is20180101132611(string transformation by YYYYMMDDHHmmSS) - 7*24*60*60
I tried in MySQL 5.7 and had same result. And it ends up with error when this calculation used in
WHERE
clause.