fix "field doesn't have a default values" error

[r4sas]

Otherwise cron will return error: Failed to update share statistics for %username%: SQL Query failed: 1364

I using pool with prop payout, and always see that error. That will fix it.

[TheSerapher]

For this to be merged we will need to add an upgrade script for existing databases, add the new version for the DB structure and update the version file too to reflect the expected DB version. Just the base file will only help people with new setups not existing ones.

And the PR should be against development not master.

I guess you have miners without any valid shares, only invalid ones, hence the error.

[r4sas]

upgrade script for existing databases

Will do

And the PR should be against development not master.

Hm... It against development branch

I guess you have miners without any valid shares, only invalid ones, hence the error.

According to updateShareStatistics function, you update values not in all fields, that's why we got error. Maybe here we also must fill pplns_valid and pplns_invalid fields with $aStats['pplns_valid'] and $aStats['pplns_invalid']?

[TheSerapher]

My bad, mobile app doesn't show the branch. All good! I am fairly sure we dont need to fill with PPLNS data, those are already archived shares which are not required in the statistics since they were already parsed for regular payouts.

[TheSerapher]

Did you give that upgrade script a quick test run? :)

[r4sas]

Currently testing it

[r4sas]

Now should work as intended

[TheSerapher]

Thanks! I will merge into dev for people to test it.