Issue 875 - Manual and Auto TXFee

[nicoschtein]

Please review this and test AFTER you have fully reviewed this, since it plays with coin client transactions amounts.

Also check if i'm missing any file that shoud be modified too.

Closes #875 when merged.

[TheSerapher]

Removed all nonsense comments. I mixed up txfee with pool fee :/

Looks great! I am pretty sure this should work but I'd like someone else to test this too if possible.

[ghost]

Looks good to me, but doesn't seem to initialize txfee_manual and txfee_auto with a default if it's not specified in the global.inc.php file. I guess by default it should be the same as the old txfee for both?

[TheSerapher]

Configuration updates are not using a default fallback. That would add a lot of temporary code during development. Just ensure you don't do a blind git pull. If the dist config was updated or SQL files were added, make sure to check what has changed.

[nicoschtein]

So, has anyone tested this yet?

I did search using github web search for txfee and modified it everywhere it was found, has anyone found a file that has to be modified and has not?

N I C O

On Wed, Dec 11, 2013 at 7:12 AM, Sebastian Grewe notifications@github.com
wrote:

Configuration updates are not using a default fallback. That would add a lot of temporary code during development. Just ensure you don't do a blind git pull. If the dist config was updated or SQL files were added, make sure to check what has changed.

Reply to this email directly or view it on GitHub:
#929 (comment)

[TheSerapher]

It's more an issue with pools upgrading and not having those new options :) Then the payout fees won't be applied and you get array errors on payouts.

You can test this by removing the options, payouts run into issues then.

Other than that it should be good enough. It's a straight forward change and doesn't affect many places.

[nicoschtein]

This is somewhat offtopic.. Many pool ops just git pull without looking
for diffs in config or db... I have been thinking how could we prevent an
error for an outdated config file and i couldn't come up with any way. All
pool ops must check that before pulling.. It is our job not to blindly pull
the repo...

2013/12/11 Sebastian Grewe notifications@github.com

It's more an issue with pools upgrading and not having those new options
:) Then the payout fees won't be applied and you get array errors on
payouts.

You can test this by removing the options, payouts run into issues then.

Other than that it should be good enough. It's a straight forward change
and doesn't affect many places.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/929#issuecomment-30328222
.

[TheSerapher]

@nicoschtein Rebase and re-push this PR so I can merge it :)

[nicoschtein]

Will do!

2013/12/16 Sebastian Grewe notifications@github.com

@nicoschtein https://github.com/nicoschtein Rebase and re-push this PR
so I can merge it :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/929#issuecomment-30659659
.

[CaptainAK]

Just an FYI, but I have been running this now for several days along with the new payouts.php and it has been running perfectly.

[TheSerapher]

Thanks! Once nico updates the PR I shall merge it. If possible join IRC for all those people pulling blindly ;-)

[nicoschtein]

Finally! check Pull Request #1039