Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up of mrpt-vision API #120

Closed
7 tasks done
jlblancoc opened this issue Jan 7, 2015 · 1 comment · Fixed by #937
Closed
7 tasks done

Clean-up of mrpt-vision API #120

jlblancoc opened this issue Jan 7, 2015 · 1 comment · Fixed by #937
Labels
enhancement
Milestone
Release 2.0.0-alpha

Comments

@jlblancoc
Copy link
Member

jlblancoc commented Jan 7, 2015 •
edited
Loading

To-do list:
@jlblancoc jlblancoc added this to the Release 2.0.0 milestone Jan 7, 2015
@jlblancoc jlblancoc mentioned this issue Apr 23, 2016
Closed
@jlblancoc jlblancoc mentioned this issue Apr 11, 2018
Merged
@jlblancoc jlblancoc mentioned this issue Apr 23, 2018
Closed
@jlblancoc jlblancoc mentioned this issue Oct 29, 2018
Merged
jlblancoc added a commit that referenced this issue Nov 9, 2018
@jlblancoc
remove GPL code for SIFT Hess, and all old SIFT impls
b89fbe3 
Progress with #120
jlblancoc added a commit that referenced this issue Nov 10, 2018
@jlblancoc
remove GPL code for SIFT Hess, and all old SIFT impls
a12c68b 
Progress with #120
jlblancoc added a commit that referenced this issue Nov 10, 2018
@jlblancoc
remove GPL code for SIFT Hess, and all old SIFT impls
fdcfa89 
Progress with #120
@jlblancoc jlblancoc mentioned this issue Nov 10, 2018
Merged
@jlblancoc
Copy link
Member Author

Update on this one:
I think CFeatureList should be entirely removed, leaving only TSimpleFeatureList for feature points, and a new alternative to CFeatureList for storing descriptors.

Part of this was done in #889 , but the alternative to CFeatureList is left as future work since it's not urgent for me right now.

Note that CFeatureList is used in some past-years GSoC GUI apps, so refactoring would imply some amount of work.

IMO, this ticket would be a good GSoC 2019 project, BTW...

jlblancoc added a commit that referenced this issue Jul 7, 2019
@jlblancoc
More TO-DOs handled
6c727a1 
cc: #120
@jlblancoc jlblancoc mentioned this issue Jul 7, 2019
Merged
4 tasks
jlblancoc added a commit that referenced this issue Jul 9, 2019
@jlblancoc
Refactor CFeatureLists
79e9956 
- Use values instead of shared_ptr for each feature (!), and simplify.
- Rename TSimpleFeature -> TKeyPoint.
- Reuse TKeyPoint inside CFeature.

related to #120.

WIP vision clean up

WIP done with libs and apps

fix examples build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 2.0.0-alpha
Development

Successfully merging a pull request may close this issue.

mrpt-vision clean up MRPT/mrpt
1 participant
@jlblancoc