chore: refactor resolve command #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekrich
force-pushed
the
chore/refactor-resolve-command
branch
from
7ef56e9 to
bf0cc3c
Compare
PaulTaykalo
requested changes
Jun 24, 2025
| ```sh | ||
| ./Binary/binary-dependencies-manager \ | ||
| --dependencies path/to/dependencies.json \ | ||
| --config path/to/.binary-dependencies.yaml \ |
README.md
Outdated
| output: MyLibrary | ||
| - repo: AnotherOrg/AnotherBinary | ||
| tag: 0.9.0 | ||
| checksum: d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2 |
Collaborator
There was a problem hiding this comment.
some easter egg will be great here. i.e.
Member
Author
There was a problem hiding this comment.
Done. It's a hash sum of MacPaw ❤️
| cacheDirectoryPath: cacheDirectoryPath, | ||
| outputDirectoryPath: outputDirectoryPath | ||
| dependencies: configuration!.dependencies, | ||
| cacheDirectoryPath: cacheDirectoryPath!, |
Collaborator
There was a problem hiding this comment.
run throws. No force casts, please
assertionFailure, preconditionafailure. not force casts
nekrich
commented
Jun 24, 2025
| import Utils | ||
|
|
||
| public struct DependenciesResolverRunner { | ||
| public struct DependenciesResolverRunner: Codable { |
Member
Author
There was a problem hiding this comment.
Storing it as a var in the ParsableCommand requires it to be Decodable
Collaborator
There was a problem hiding this comment.
This is wrong on so many levels.. can we just creat this runner in Run? and avoid having this as a property?
nekrich
force-pushed
the
chore/refactor-resolve-command
branch
from
bfe3dac to
bdd40ed
Compare
nekrich
force-pushed
the
chore/refactor-resolve-command
branch
from
bdd40ed to
3d5d165
Compare
PaulTaykalo
approved these changes
Jun 24, 2025
nekrich
added a commit
that referenced
this pull request
Jun 26, 2025
* chore: refactor resolve command * chore: update resolve command * chore: add precondition * chore: add easter egg * chore: store dependenciesResolver * chore: fix unwrapping
nekrich
added a commit
that referenced
this pull request
Jul 1, 2025
…rt (#30) * chore: ignore SPM folders * chore: add BinaryDependenciesConfiguration (#9) * chore: add yams (#7) * chore: add config reader (#10) * fix: make sure that tests can be ran with `BinaryDependencyManager` target (#8) * fix: rename BinaryDependenciesManager to binary_dependencies_manager * fix: Make sure that target naming is CamelCase and tests works * fix: add Utils which is used from the Manager and the Runenr * fix: Add binary file to exclude * chpore: fix imports --------- Co-authored-by: Paul Taykalo <ptaykalo@macpaw.com> * chore: chore: add CLI and GitHub (#12) * chore: add Asset to Dependency (#13) * chore: add version (#11) * chore: public interface (#14) * chore: add BinaryDependenciesDownloader (#16) * chore: add GenericError (#17) * chore: add version to the BinaryDependenciesManager (#18) * chore: refactor resolve command (#15) * chore: refactor resolve command * chore: update resolve command * chore: add precondition * chore: add easter egg * chore: store dependenciesResolver * chore: fix unwrapping * chore: update file manager protocol (#20) * chore: remove unneded downloadSourceCode method (#26) * fix: resolve command (#23) * chore: update CleanCommand (#22) * chore: validate CLI run exit code (#24) * chore: Utils tests target (#25) * chore: add copyItem to FileManagerProtocol (#33) * chore: add ChecksumCalculatorProtocol (#32) * ci: add test workflow [refactor branch] (#28) * ci: add test workflow * fix(ci): linux build * chore: specify derived data for xcodebuild * chore: update Sources/BinaryDependencyManager/Utils/BinaryDependenciesConfigurationReader.swift * chore: refactor runner (#19) * chore: refactor DepeneciesResolverRunner * chore: Tests cleanup (#34) * Remove deduplication and simplify test setup * A bit refactored tests * fix: failing test with uuid neste temp dir * fix: unwrapping * chore: bump min target (#35) --------- Co-authored-by: Paul Taykalo <ptaykalo@macpaw.com> * chore: refactor download tests (#36) * fix: ci compilation (#38) * chore: refactor tests (#37) * chore: standartize file URLs and update tests (#39) --------- Co-authored-by: Paul Taykalo <ptaykalo@macpaw.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
ResolveCommand refactoring.
--config/-c.Type of Change
Checklist
Screenshots (if applicable)
Additional Context
Add any other context or screenshots about the pull request here.