Skip to content

chore: remove unneded downloadSourceCode method #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

chore: remove unneded downloadSourceCode method #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions Sources/BinaryDependencyManager/Utils/BinaryDependenciesDownloader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
/// A protocol for downloading binary dependencies from git repositories.
protocol BinaryDependenciesDownloader {
/// Downloads the source code as a zip archive from the specified repo and release tag.
///
/// - Parameters:
/// - repo: Git repository, e.g. "owner/repo".
/// - tag: The release tag to download.
/// - outputFilePath: The output file path for the downloaded archive.
/// - Throws: If the download fails.
func downloadSourceCode(
repo: String,
tag: String,
outputFilePath: String
) throws
import Utils

/// A protocol for downloading binary dependencies from git repositories.
public protocol BinaryDependenciesDownloader {
/// Downloads a specific release asset from git repo matching the provided pattern.
///
/// - Parameters:
Expand Down
29 changes: 0 additions & 29 deletions Sources/Utils/CLI/CLI+GitHub.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,35 +33,6 @@ extension CLI.GitHub {
)
}

/// Downloads the source code as a zip archive from the specified repo and release tag using `gh`.
///
/// - Parameters:
/// - repo: GitHub repository, e.g. "owner/repo".
/// - tag: The release tag to download.
/// - outputFilePath: The output file path for the downloaded archive.
/// - Throws: If the download fails.
public func downloadSourceCode(
repo: String,
tag: String,
outputFilePath: String
) throws {
let arguments: [String] = [
["release"],
["download"],
["\(tag)"],
["--archive=zip"],
["--repo", "\(repo)"],
["--output", "\(outputFilePath)"]
].flatMap { $0 }

Logger.log("[Download] ⬇️ \(repo) source code with tag \(tag) to \(outputFilePath)")

try run(
arguments: arguments,
currentDirectoryURL: outputFilePath.asFileURL.deletingLastPathComponent()
)
}

/// Downloads a specific release asset from GitHub matching the provided pattern using `gh`.
///
/// - Parameters:
Expand Down