Skip to content

use qemu on github CI for ppc64le, s390x #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −0
Open

use qemu on github CI for ppc64le, s390x #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc90da4
use qemu on github CI for ppc64le, s390x
mattip Nov 3, 2025
83ab73c
typo
mattip Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/posix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ jobs:
- { os: ubuntu-24.04-arm, PLAT: aarch64, INTERFACE64: '0', MB_ML_VER: '_1_2', MB_ML_LIBC: musllinux}
- { os: ubuntu-24.04-arm, PLAT: aarch64, INTERFACE64: '1', MB_ML_VER: '_1_2', MB_ML_LIBC: musllinux}

- { os: ubuntu-latest, PLAT: ppc64le, INTERFACE64: '0', MB_ML_VER: '2014', MB_ML_LIBC: manylinux}
- { os: ubuntu-latest, PLAT: ppc64le, INTERFACE64: '1', MB_ML_VER: '2014', MB_ML_LIBC: manylinux}

- { os: ubuntu-latest, PLAT: s390x, INTERFACE64: '0', MB_ML_VER: '2014', MB_ML_LIBC: manylinux}
- { os: ubuntu-latest, PLAT: s390x, INTERFACE64: '1', MB_ML_VER: '2014', MB_ML_LIBC: manylinux}

env:
NIGHTLY: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
MB_ML_LIBC: ${{ matrix.MB_ML_LIBC }}
Expand All @@ -68,6 +74,12 @@ jobs:
with:
xcode-version: '15.4'

- name: Set up QEMU
if: runner.os == 'Linux' && runner.arch == 'X64'
uses: docker/setup-qemu-action@v3
with:
platforms: all

- name: Print some Environment variable
run: |
echo "PLAT: ${PLAT}"
Expand Down
3 changes: 3 additions & 0 deletions tools/build_steps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,14 @@ EOF
export DYLD_LIBRARY_PATH=/usr/local/lib:$DYLD_LIBRARY_PATH
;;
*-s390x)
# The TargetList.txt has only ZARCH_GENERIC, Z13, Z14. Not worth
# messing with dynamic lists and targets.
local bitness=64
Comment on lines +185 to 186
Copy link
Contributor

@mayeut mayeut Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# messing with dynamic lists and targets.
local bitness=64
# messing with dynamic lists.
local bitness=64
local target="ZARCH_GENERIC"

see https://github.com/OpenMathLib/OpenBLAS/blob/f6df9bebbb4259aa61ab5634c0f1269fb152cc0e/README.md?plain=1#L271-L273

;;
*-ppc64le)
local bitness=64
local target="POWER8"
local dynamic_list="POWER8 POWER10"
Copy link
Contributor

@mayeut mayeut Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local dynamic_list="POWER8 POWER10"

ppc64le does not support dynamic list

Copy link
Collaborator Author

@mattip mattip Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README seems to imply that DYNAMIC_LIST is supported

For POWER, the list encompasses POWER6, POWER8 and POWER9. POWER10 is additionally available if a sufficiently recent compiler is used for the build.

Copy link
Contributor

@mayeut mayeut Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DYNAMIC_ARCH is supported with this list (depending on compiler), but user provided DYNAMIC_LIST is not supported (either on purpose or an oversight) in https://github.com/OpenMathLib/OpenBLAS/blob/develop/Makefile.system

Copy link
Collaborator Author

@mattip mattip Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. Is there an open OpenBLAS issue about the missing DYNAMIC_LIST override of DYNAMIC_CORE?

;;
Linux-loongarch64)
local target="GENERIC"
Expand Down
Loading