Import Literal type from typing_extensions if python version<3.8 #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing.Literalwas added in Python 3.8, so type checkers will fail trying to import it ifpython_version<3.8This PR does the following:
Literalfromtyping_extensionsifpython_version<3.8.typing_extensionsas an install requirement ifpython_version<3.8.Not sure if we want
2.though. One alternative would be to remove the one instance ofLiteral[False]that we have in the.pyifile.