Fix errors when a kwarg is named "col" #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hukkin
changed the title
hukkin
commented
May 9, 2020
| def test_kwarg_named_col(self): | ||
| self.assertEqual(dict(self.Map(col=0)), {"col": 0}) | ||
| self.assertEqual(dict(self.Map(a=0, col=1)), {"a": 0, "col": 1}) | ||
| self.assertEqual(dict(self.Map({"a": 0}, col=1)), {"a": 0, "col": 1}) |
Author
There was a problem hiding this comment.
All of these three asserts used to fail when running in PyMapTest. They now pass with the changes in this MR.
This test makes very little sense now that the keyword arg called "col" has been refactored out, though. Should we keep it or not?
1st1
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
It seems there is an inconsistency in how the Python and C implementations handle a
Map.__init__,Mapy.update, orMapMutation.updatekeyword argument that is named "col". The C implementation works similarly to the builtindictinit. Python implementation seems to have some issues though.Changes in this PR
Map.__init__,Map.updateandMapMutation.update. Assume that if there is a positional arg, it must be a collection, do not care about the name "col".