Readd Package abstract class that was removed in #96 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically commit c99c63b Previously Rpm < Package < LinuxAdmin, and LinuxAdmin is where the .run method comes from. By removing Package, Rpm broke by not having access to .run. This readds the class to fix that issue.
|
Checked commit Fryguy@f4f8742 with rubocop 0.21.0 |
|
@Fryguy Nice. It seems really weird to be calling run! from within the Rpm class anyway. Too much magic. How would anyone know that Rpm is really calling LinuxAdmin.run! through inheritance delegates to AwesomeSpawn run! |
jrafanie
added a commit
that referenced
this pull request
Jul 10, 2014
Readd Package abstract class that was removed in #96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in #96, Specifically commit c99c63b
Previously Rpm < Package < LinuxAdmin, and LinuxAdmin is where
the .run method comes from. By removing Package, Rpm broke
by not having access to .run. This readds the class to fix
that issue.